克隆节点[golang.org/x/net/html]:堆栈溢出

时间:2017-03-05 17:45:23

标签: go tree

我正在尝试克隆/复制html Node,以便我可以修改/复制它,然后将其注入主文档中。问题是我得到了堆栈溢出[2]。我认为有竞争条件。看起来它应该是ParentPrevSibling字段(基于我的盲测)。知道为什么会这样,我怎么能完全克隆它(以便它可以在reflect.DeepEqual上测试为正)?

func clone(src *html.Node) *html.Node {
    if src == nil {
        return nil
    }
    n := html.Node{
        Parent:      clone(src.Parent),
        FirstChild:  clone(src.FirstChild),
        LastChild:   clone(src.LastChild),
        PrevSibling: clone(src.PrevSibling),
        NextSibling: clone(src.NextSibling),

        Type:      src.Type,
        DataAtom:  src.DataAtom,
        Data:      src.Data,
        Namespace: src.Namespace,
    }
    for _, v := range n.Attr {
        n.Attr = append(n.Attr, v)
    }
    return &n
}

[2]

runtime: goroutine stack exceeds 1000000000-byte limit
fatal error: stack overflow

runtime stack:
runtime.throw(0x3495b9, 0xe)
    /Users/x/gosrc/src/runtime/panic.go:566 +0x95
runtime.newstack()
    /Users/x/gosrc/src/runtime/stack.go:1061 +0x416
runtime.morestack()
    /Users/x/gosrc/src/runtime/asm_amd64.s:366 +0x7f

goroutine 7 [running]:
runtime.heapBitsSetType(0xc42a0ae5b0, 0x70, 0x68, 0x32e420)
    /Users/x/gosrc/src/runtime/mbitmap.go:867 fp=0xc4402002a8 sp=0xc4402002a0
runtime.mallocgc(0x70, 0x32e420, 0x1, 0x0)
    /Users/x/gosrc/src/runtime/malloc.go:690 +0x5ba fp=0xc440200348 sp=0xc4402002a8
runtime.newobject(0x32e420, 0x0)
    /Users/x/gosrc/src/runtime/malloc.go:785 +0x38 fp=0xc440200378 sp=0xc440200348
bitbucket.org/x/y/client.clone(0xc420138d20, 0x0)

1 个答案:

答案 0 :(得分:0)

深度克隆包含非<树>指针的数据结构时,需要更复杂的方法;如果你打电话

 n := Node{...
           next:clone(src.next),
           prev:clone(src.prev),
           ...}

并且您的结构甚至只有两个兄弟节点n1n2其中n1.next&n2n2.prev&n1代码将堆栈溢出(克隆n1将为clone(n2)指针调用next,而clone(n1)指针又将prev指针调用src→cloned,来回循环直到调用堆栈爆炸)。

解决方案是保留“缓存”,在克隆节点时,您将存储package main import "fmt" type Node struct { value int prev, next *Node } func clone(n *Node, cache map[*Node]*Node) *Node { if n == nil { return nil } if val, ok := cache[n]; ok { return val } val := &Node{} cache[n] = val val.value = n.value val.prev = clone(n.prev, cache) val.next = clone(n.next, cache) return val } func printlist(n *Node) { for n != nil { println(fmt.Sprintf("address=%p, value=%v, prev=%p, next=%p", n, n.value, n.prev, n.next)) n = n.next } } func main() { n1 := &Node{} n2 := &Node{} n3 := &Node{} n1.value = 100 n2.value = 200 n3.value = 300 n1.next = n2 n2.prev = n1 n2.next = n3 n3.prev = n2 printlist(n1) println("Cloning list") c1 := clone(n1, make(map[*Node]*Node)) printlist(c1) } 关联,因此克隆过程将能够在递归结构的情况下返回节点。

以下是一个完整的最小例子:

~/x$ go run recstruct.go
address=0xc42000e540, value=100, prev=0x0, next=0xc42000e560
address=0xc42000e560, value=200, prev=0xc42000e540, next=0xc42000e580
address=0xc42000e580, value=300, prev=0xc42000e560, next=0x0
Cloning list
address=0xc42000e5c0, value=100, prev=0x0, next=0xc42000e5e0
address=0xc42000e5e0, value=200, prev=0xc42000e5c0, next=0xc42000e600
address=0xc42000e600, value=300, prev=0xc42000e5e0, next=0x0
~/x$ 

在我的机器上运行这个程序我得

{{1}}

您可以在其中看到三个节点已正确克隆,并且prev / next在克隆结构列表中相互指向。