如何在模型上的模块扩展之前进行AR验证？

时间：2016-11-13 20:24:32

标签： ruby-on-rails validation ruby-on-rails-5 friendly-id

我正在使用FriendlyID，它会在创建时根据记录的某些属性创建一个slug。

  extend FriendlyId
  friendly_id :name_and_school, use: :slugged

  def name_and_school
    "#{first_name} #{last_name} #{school.name}"
  end

我的模型上也有以下内容：

  validates :first_name, :last_name, presence: true
  validates_associated :school, presence: true

但是，当我去测试此验证并提交first_name, last_name and school的空值表单时，我收到以下错误：

  Position Load (0.8ms)  SELECT "positions".* FROM "positions" WHERE 1=0
   (0.8ms)  BEGIN
   (0.6ms)  ROLLBACK
Completed 500 Internal Server Error in 51ms (ActiveRecord: 11.7ms)



NoMethodError - undefined method `name' for nil:NilClass:
  app/models/profile.rb:79:in `name_and_school'
  friendly_id (5.1.0) lib/friendly_id/slugged.rb:295:in `should_generate_new_friendly_id?'
  friendly_id (5.1.0) lib/friendly_id/slugged.rb:304:in `set_slug'

明确的是，即使在它进入ActiveRecord的验证检查之前，它正在使用name_and_school方法。

如果它首先达到验证检查，则不会生成此错误，只会重新加载具有相应错误的页面。

那么如何解决这个问题并确保只有在所有验证都通过后才会生成FriendlyID slug？

修改1

所以我试着坚持name_and_school只返回一个有效字符串，如果这些值存在，那么：

  def name_and_school
    "#{first_name} #{last_name} #{school.name}" if first_name.present? && last_name.present? && school.present?
  end

这适用于空/无效first_name和last_name属性。

但是，当我将学校字段留空时，它现在给了我这个错误：

Completed 500 Internal Server Error in 31689ms (Searchkick: 9.5ms | ActiveRecord: 23.6ms)

NoMethodError - undefined method `name' for nil:NilClass:
  app/models/profile.rb:139:in `search_data'
  searchkick (1.4.0) lib/searchkick/index.rb:289:in `search_data'
  searchkick (1.4.0) lib/searchkick/index.rb:66:in `block in bulk_index'
  searchkick (1.4.0) lib/searchkick/index.rb:66:in `bulk_index'
  searchkick (1.4.0) lib/searchkick/index.rb:54:in `store'
  searchkick (1.4.0) lib/searchkick/logging.rb:28:in `block in store'
  activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `block in instrument'
  activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:21:in `instrument'
  activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `instrument'
  searchkick (1.4.0) lib/searchkick/logging.rb:27:in `store'
  searchkick (1.4.0) lib/searchkick/index.rb:96:in `reindex_record'
  searchkick (1.4.0) lib/searchkick/model.rb:113:in `reindex'
  app/models/profile.rb:146:in `reindex_profile'

在我的模型中对应于此：

after_commit :reindex_profile

  def search_data
    {
      name: name,
      bib_color: bib_color,
      height: height,
      weight: weight,
      player_type: player_type,
      school_name: school.name,
      age: age,
      position_name: positions.map(&:name)
    }
  end

  def reindex_profile
    reindex
  end

提交新记录后，它会运行该回调 - 它需要一个有效的school属性。

因此nil值仍在逃避validates_associated检查。

我甚至尝试将相同的if语句添加到reindex_profile方法中，如下所示：

  def reindex_profile
    reindex if first_name.present? && last_name.present? && school.present? && bib_color.present? && player_type.present? && age.present?
  end

但这也不起作用。

修改2

在尝试@ codyeatworld的回答之后，我们正在取得进展。

现在的问题是，即使我没有再收到这些错误，尽管validates_associated :school, presence: true不是真的，但仍会创建记录。

例如，以下是请求的示例：

Started POST "/profiles" for ::1 at 2016-11-13 16:32:19 -0500
Processing by ProfilesController#create as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"skJA+9NB3XhR/JLgQ==", "profile"=>{"avatar"=>#<ActionDispatch::Http::UploadedFile:0x007fbf3b35d9a8 @tempfile=#<Tempfile:/var/folders/0f/hgplttnd7d/T/RackMultipart20161113-16651-1wvdzdx.jpg>, @original_filename="Random-Image.jpg", @content_type="image/jpeg", @headers="Content-Disposition: form-data; name=\"profile[avatar]\"; filename=\"Random-Image.jpg\"\r\nContent-Type: image/jpeg\r\n">, "first_name"=>"Random", "last_name"=>"Brown", "dob(3i)"=>"13", "dob(2i)"=>"11", "dob(1i)"=>"1986", "weight"=>"", "height"=>"", "bib_color"=>"", "player_type"=>"player", "position_ids"=>[""], "school_id"=>"", "grade"=>"", "tournament_ids"=>[""], "email"=>"", "cell_phone"=>"", "home_phone"=>"", "grades_attributes"=>{"0"=>{"subject"=>"", "result"=>"", "grade_type"=>"csec", "_destroy"=>"false"}}, "transcripts_attributes"=>{"0"=>{"url_cache"=>"", "_destroy"=>"false"}}, "achievements_attributes"=>{"0"=>{"body"=>"", "achievement_type"=>"academic", "_destroy"=>"false"}}, "videos_attributes"=>{"0"=>{"vimeo_url"=>"", "official"=>"", "_destroy"=>"false"}}, "articles_attributes"=>{"0"=>{"source"=>"", "title"=>"", "url"=>"", "_destroy"=>"false"}}}, "commit"=>"Create Profile"}
  User Load (1.8ms)  SELECT  "users".* FROM "users" WHERE "users"."id" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["id", 2], ["LIMIT", 1]]
  Role Load (1.8ms)  SELECT "roles".* FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND (((roles.name = 'admin') AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)))  [["user_id", 2]]
  Role Load (1.3ms)  SELECT "roles".* FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND (((roles.name = 'coach') AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)))  [["user_id", 2]]
  Role Load (1.3ms)  SELECT "roles".* FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND (((roles.name = 'player') AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)))  [["user_id", 2]]
   (1.7ms)  SELECT COUNT(*) FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND (((roles.name = 'admin') AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)) OR ((roles.name = 'coach') AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)))  [["user_id", 2]]
The "mime_type" Shrine metadata field will be set from the "Content-Type" request header, which might not hold the actual MIME type of the file. It is recommended to load the determine_mime_type plugin which determines MIME type from file content.
  Tournament Load (1.2ms)  SELECT "tournaments".* FROM "tournaments" WHERE 1=0
  Position Load (0.8ms)  SELECT "positions".* FROM "positions" WHERE 1=0
   (0.9ms)  BEGIN
  SQL (2.2ms)  INSERT INTO "profiles" ("first_name", "last_name", "dob", "bib_color", "created_at", "updated_at", "player_type", "grade", "home_phone", "cell_phone", "email", "avatar_data") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12) RETURNING "id"  [["first_name", "Yashin"], ["last_name", "Brown"], ["dob", Thu, 13 Nov 1986], ["bib_color", ""], ["created_at", 2016-11-13 21:32:19 UTC], ["updated_at", 2016-11-13 21:32:19 UTC], ["player_type", 0], ["grade", ""], ["home_phone", ""], ["cell_phone", ""], ["email", ""], ["avatar_data", "{\"id\":\"83d162a3d33bdc5d2527502e1d423ab3.jpg\",\"storage\":\"cache\",\"metadata\":{\"filename\":\"Random-Image.jpg\",\"size\":61798,\"mime_type\":\"image/jpeg\"}}"]]
  SQL (2.0ms)  INSERT INTO "transcripts" ("profile_id", "created_at", "updated_at") VALUES ($1, $2, $3) RETURNING "id"  [["profile_id", 30], ["created_at", 2016-11-13 21:32:19 UTC], ["updated_at", 2016-11-13 21:32:19 UTC]]
  Profile Load (3.7ms)  SELECT  "profiles".* FROM "profiles" WHERE "profiles"."id" = $1 LIMIT $2  [["id", 30], ["LIMIT", 1]]
   (1.6ms)  COMMIT
   (0.9ms)  BEGIN
  SQL (2.6ms)  UPDATE "profiles" SET "updated_at" = $1, "avatar_data" = $2 WHERE "profiles"."id" = $3  [["updated_at", 2016-11-13 21:32:19 UTC], ["avatar_data", "{\"id\":\"ec63dcc18ed5d60aa7a6626550f9f9ea.jpg\",\"storage\":\"store\",\"metadata\":{\"filename\":\"Random-Image.jpg\",\"size\":61798,\"mime_type\":\"image/jpeg\"}}"], ["id", 30]]
   (1.3ms)  COMMIT
  Profile Store (311.8ms)  {"id":30}
  Profile Store (32.2ms)  {"id":30}
  Profile Store (26.7ms)  {"id":30}
  Profile Store (18.9ms)  {"id":30}
Redirected to http://localhost:3000/profiles/30
Completed 302 Found in 530ms (Searchkick: 389.6ms | ActiveRecord: 32.2ms)

注意"school_id"=>""，还注意到URL现在是profiles/30（而不是FriendlyID URL，这意味着friendlyID slug没有执行，这就是我想要的）。

尽管我在模型上进行validates_associated调用，为什么仍然会创建此记录？

1 个答案:

答案 0 :(得分：1)

我认为你当时正在寻找should_generate_new_friendly_id。

def should_generate_new_friendly_id?
  first_name.present? && last_name.present? && school.present?
end

如果满足这些条件，FriendlyId将只尝试创建一个slu。

我认为searchkick中的违规行是school.name属性。

def search_data
  {
    name: name,
    bib_color: bib_color,
    height: height,
    weight: weight,
    player_type: player_type,
    # school_name: school.name,
    school_name: (school.present? ? school.name : nil),
    age: age,
    position_name: positions.map(&:name)
  }
end

我假设您要验证school的存在。方法validates_associated将运行school对象/模型的验证。它不会检查是否存在school_id。

validates :first_name, :last_name, :school_id, presence: true
# Remove validates_associated :school, presence: true

我认为你也可以省略_id：

belongs_to :school
validates :school, presence: true
相关问题
最新问题