Question

我正在尝试执行以下过程，但它说我使用BULKCOLLECT和FORALL来重构我的代码。这只是一个警告，还是我不应该使用下面的程序。如果是这样，我应该如何修改代码，因为我正在迭代数组，我需要将每个值更新到表中。

CREATE OR REPLACE PROCEDURE SCHEMA.PR_VALIDATE 
(
FILEARRAY IN STRARRAY,
DUPARRAY OUT STRARRAY,
PASSARRAY OUT STRARRAY,
FAILARRAY OUT STRARRAY,
MISSARRAY OUT STRARRAY
)

IS
dupCount NUMBER;
staCode    VARCHAR2 (10);
fileName VARCHAR2 (50);
dupfileName VARCHAR2(50);
fileId NUMBER;
ID VARCHAR2(20);
BEGIN
for i in 1 .. FILEARRAY.count
   loop
     fileName := FILEARRAY(i);


     SELECT COUNT (T.FILEID), T.FILEID,T.STATUS,T.ID INTO dupCount,fileId,staCode,ID FROM TB_TABLE_NAME T, TB_TABLE_NAME S
     WHERE T.FILEID=S.FILEID
     AND T.STATUS=S.STATUS
     AND T.FILENAME = fileName AND T.STATUS IN ('PASS', 'FAIL)
     GROUP BY T.FILEID,T.STATUS,T.ID;


     IF dupCount>1
     THEN 
     SELECT FILENAME INTO dupfileName FROM TB_TABLE_1
     WHERE STATUS IN ('PASS','FAIL') AND FILEID=fileId
     AND FILENAME != fileName;
     DBMS_OUTPUT.PUT_LINE(dupfileName);

     UPDATE TB_TABLE_1 SET STATUS='DUP' WHERE FILENAME=dupfileName;
     DUPARRAY(DUPARRAY.LAST +1 ) :=dupfileName;
     DBMS_OUTPUT.PUT_LINE(dupfileName);
     END IF;

     IF staCode = 'FAIL'
     THEN
     FAILARRAY(FAILARRAY.LAST+1) :=fileName;
     ELSIF staCode = 'PASS'
     THEN
     PASSARRAY(PASSARRAY.LAST+1) :=fileName;
     END IF;

   end loop;


EXCEPTION
    WHEN NO_DATA_FOUND THEN
    staCode :=NULL;
    MISSARRAY(MISSARRAY.LAST +1 ) :=fileName;
    WHEN OTHERS THEN
        PR_ERRORS('PR_VALIDATE', SQLERRM);
       ROLLBACK;

END;

/

Answer 1

正如我在评论FORALL中提到的那样，由于业务逻辑已合并到此处，因此不再使用上下文，但您可以尝试使用FOR循环进行BULK COLLECT迭代。但是数据量并不大，你仍然可以采用逐行方法。希望下面片段有帮助。还有一些单引号丢失会导致编译时错误。

CREATE OR REPLACE PROCEDURE SCHEMA.PR_VALIDATE(
    FILEARRAY IN STRARRAY,
    DUPARRAY OUT STRARRAY,
    PASSARRAY OUT STRARRAY,
    FAILARRAY OUT STRARRAY,
    MISSARRAY OUT STRARRAY )
IS
  dupCount    NUMBER;
  staCode     VARCHAR2 (10);
  fileName    VARCHAR2 (50);
  dupfileName VARCHAR2(50);
  fileId      NUMBER;
  ID          VARCHAR2(20);
BEGIN
  FOR i IN 1 .. FILEARRAY.count
  LOOP
    fileName := FILEARRAY(i);
    SELECT COUNT (T.FILEID),
      T.FILEID,
      T.STATUS,
      T.ID
    INTO dupCount,
      fileId,
      staCode,
      ID
    FROM TB_TABLE_NAME T,
      TB_TABLE_NAME S
    WHERE T.FILEID =S.FILEID
    AND T.STATUS   =S.STATUS
    AND T.FILENAME = fileName
    AND T.STATUS  IN ('PASS', 'FAIL')
    GROUP BY T.FILEID,
      T.STATUS,
      T.ID;
    IF dupCount>1 THEN
      SELECT FILENAME
      INTO dupfileName
      FROM TB_TABLE_1
      WHERE STATUS IN ('PASS','FAIL')
      AND FILEID    =fileId
      AND FILENAME != fileName;
      DBMS_OUTPUT.PUT_LINE(dupfileName);

      UPDATE TB_TABLE_1 
      SET STATUS='DUP' 
      WHERE FILENAME=dupfileName;

      DUPARRAY(DUPARRAY.LAST +1 ) :=dupfileName;
      DBMS_OUTPUT.PUT_LINE(dupfileName);
    END IF;

    IF staCode                     = 'FAIL' THEN
      FAILARRAY(FAILARRAY.LAST+1) :=fileName;
    ELSIF staCode                  = 'PASS' THEN
      PASSARRAY(PASSARRAY.LAST+1) :=fileName;
    END IF;
  END LOOP;
EXCEPTION
WHEN NO_DATA_FOUND THEN
  staCode                       :=NULL;
  MISSARRAY(MISSARRAY.LAST +1 ) :=fileName;
WHEN OTHERS THEN
  PR_ERRORS('PR_VALIDATE', SQLERRM);
  ROLLBACK;
END;

过程

1 个答案: