我有一个Spring MVC应用程序,我使用Aspect来捕获所有控制器方法中的异常
@Component
@Aspect
public class ControllerExceptionAspect {
private Logger logger;
public ControllerExceptionAspect() {
logger = Logger.getLogger(ControllerExceptionAspect.class);
}
public ControllerExceptionAspect(Logger logger) {
this.logger = logger;
}
// Catching all exceptions from all methods in all controllers classes
@AfterThrowing(pointcut = "execution(* com.my.package..controller..*(..))", throwing = "exception")
public void afterThrowingAdvice(Exception exception) {
logger.error("CONTROLLER ASPECT: EXCEPTION IN METHOD -> " +
exception.getClass());
}
}
看点工作正常但不幸的是我无法测试它。我尝试了很多次,但是在模拟Controller
中的异常之后无法知道是否调用了Aspect方法@SuppressWarnings("ALL")
@RunWith(SpringJUnit4ClassRunner.class)
@WebAppConfiguration
@ContextHierarchy({
@ContextConfiguration(classes = RootConfig.class),
@ContextConfiguration(classes = WebConfig.class)
})
public class ControllerExceptionAspectTest {
@Autowired
ApplicationContext applicationContext;
@Test
public void testControllerExceptionAspectGetsExecutedWhenExceptionOccures(){
HomeController homeController = (HomeController)applicationContext.getAutowireCapableBeanFactory().getBean("homeController");
try{homeController.callMethod("00000");}
catch (Exception e){}
ControllerExceptionAspect controllerExceptionAspect = (ControllerExceptionAspect)applicationContext.getAutowireCapableBeanFactory().getBean("controllerExceptionAspect");
// HOW TO CATCH THAT ASPECT METHOD WAS CALLED???
}
}
答案 0 :(得分:6)
我认为你想要实现的是测试你创建的配置(方面切入点),而不是可以进行单元测试的方面本身。我担心的是,没有简单的方法可以实现这一点。
您可以按照一些关于捕获日志或其他想法的互联网建议。老实说,只有当你真的需要测试它被调用时,我才会测试Aspect的预期行为。如果它正在登录我就不会这样做。如果它正在设置db(或其他副作用),我将验证该值是否在db中。这是集成测试的草率基础。
如果你真的必须按照你想要的方式测试方面,你可以写一些类似于给定代码的东西。但请记住,正常(非测试)运行时弹簧配置需要在Spring上下文中存在Verifier接口的虚拟实现。
@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(Config.class)
public class AspectTesting {
@Autowired
ServiceWithAspect service;
@Autowired
Verifier verifyingAspect;
@Test
public void test() {
// given
boolean condition = false;
// when
try {
service.doit();
} catch (Exception swallow) {}
// then
try {
condition = ((VerifyingAspect) ((Advised) verifyingAspect).getTargetSource().getTarget()).wasExecuted();
} catch (Exception swallow) {}
// then
Assert.assertTrue(condition);
}
}
@Configuration
@EnableAspectJAutoProxy
@ComponentScan("aspects")
class Config {
}
@Component
class VerifyingAspect implements Verifier {
private boolean executed = false;
public boolean wasExecuted() {
return executed;
}
@Override
public void invoked() {
executed = true;
}
}
@Service
class ServiceWithAspect {
public void doit() {
throw new RuntimeException();
}
}
@Component
@Aspect
class TestedAspect {
@Autowired
Verifier verifier;
@AfterThrowing(pointcut = "execution(* *(..))", throwing = "exception")
public void afterThrowingAdvice(Exception exception) {
// your aspect logic here
verifier.invoked();
}
}
interface Verifier {
void invoked();
}
答案 1 :(得分:0)
非常容易地单独测试一个方面(包括其切入点表达式),而无需整个Web上下文(或根本没有任何上下文)。
我将首先尝试给出一个概括的例子,而不是OP问题中的例子。
让我们想象一下,如果方法的第一个参数为null,则必须具有抛出异常的方面,否则将允许方法调用继续进行。
仅应将其应用于使用我们的自定义@ThrowOnNullFirstArg
注释进行注释的控制器。
@Aspect
public class ThrowOnNullFirstArgAspect {
@Pointcut("" +
"within(@org.springframework.stereotype.Controller *) || " +
"within(@(@org.springframework.stereotype.Controller *) *)")
private void isController() {}
@Around("isController()")
public Object executeAroundController(ProceedingJoinPoint point) throws Throwable {
throwIfNullFirstArgIsPassed(point);
return point.proceed();
}
private void throwIfNullFirstArgIsPassed(ProceedingJoinPoint point) {
if (!(point.getSignature() instanceof MethodSignature)) {
return;
}
if (point.getArgs().length > 0 && point.getArgs()[0] == null) {
throw new IllegalStateException("The first argument is not allowed to be null");
}
}
}
我们可以这样测试:
public class ThrowOnNullFirstArgAspect {
private final ThrowOnNullFirstArgAspect aspect = new ThrowOnNullFirstArgAspect();
private TestController controllerProxy;
@Before
public void setUp() {
AspectJProxyFactory aspectJProxyFactory = new AspectJProxyFactory(new TestController());
aspectJProxyFactory.addAspect(aspect);
DefaultAopProxyFactory proxyFactory = new DefaultAopProxyFactory();
AopProxy aopProxy = proxyFactory.createAopProxy(aspectJProxyFactory);
controllerProxy = (TestController) aopProxy.getProxy();
}
@Test
public void whenInvokingWithNullFirstArg_thenExceptionShouldBeThrown() {
try {
controllerProxy.someMethod(null);
fail("An exception should be thrown");
} catch (IllegalStateException e) {
assertThat(e.getMessage(), is("The first argument is not allowed to be null"));
}
}
@Test
void whenInvokingWithNonNullFirstArg_thenNothingShouldBeThrown() {
String result = controllerProxy.someMethod(Descriptor.builder().externalId("id").build());
assertThat(result, is("ok"));
}
@Controller
@ThrowOnNullFirstArg
private static class TestController {
@SuppressWarnings("unused")
String someMethod(Descriptor descriptor) {
return "ok";
}
}
}
关键部分在setUp()
方法内部。请注意,它还可以验证切入点表达式的正确性。
如果Aspect方法仅具有某些难以在测试中验证的效果,则可以使用Mockito之类的模拟库并在实际方面周围创建一个存根,然后验证该方法是否已被实际调用。
private ControllerExceptionAspect aspect = Mockito.stub(new ControllerExceptionAspect());
然后在通过代理调用控制器之后进行测试
Mockito.verify(aspect).afterThrowingAdvice(Matchers.any());
如果您使用经典的logback,则可以编写一个Appender
实现并将其添加到感兴趣的Logger
中,然后检查您期望的消息是否被记录。
public class TestAppender extends AppenderBase<ILoggingEvent> {
public List<ILoggingEvent> events = new ArrayList<>();
@Override
protected void append(ILoggingEvent event) {
events.add(event);
}
}
在灯具设置中:
appender = new TestAppender();
// logback Appender must be started to accept messages
appender.start();
ch.qos.logback.classic.Logger logger = (ch.qos.logback.classic.Logger) LoggerFactory.getLogger(ControllerExceptionAspect.class.class);
logger.addAppender(appender);
并在您的测试中:
List<ILoggingEvent> errors = appender.events.stream()
.filter(event -> event.getLevel() == Level.ERROR)
.collect(Collectors.toList());
assertEquals("Exactly one ERROR is expected in log", 1, errors.size());
// any other assertions you need
可能您还需要stop()
方法中的Appender
@After
,但是我不确定。