对于Iterable的自定义匹配器,什么是正确的签名?

时间:2015-10-08 10:48:09

标签: java generics matcher hamcrest

我正在尝试为具有Iterable字段的类编写自定义匹配器。我无法找到一种方法来实现它,以便它可以接受任何匹配器 everyItem hasItem 包含 - 因为每个这些返回略有不同的泛型类型。这样做的最佳方式是什么?

这是一个演示问题的简单示例 - 如何编译?我正在使用Hamcrest 1.3。

import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.everyItem;
import static org.hamcrest.Matchers.hasItem;
import static org.junit.Assert.assertThat;

import java.util.Collection;

import org.hamcrest.Description;
import org.hamcrest.Matcher;
import org.hamcrest.TypeSafeDiagnosingMatcher;

    public class MatcherExample {

        public static class Band {
            public Collection<Member> getMembers() {
                return null;
            }
        };

        public static class Member {
        };

        public static Matcher<Band> hasMembers(final Matcher<Iterable<Member>> matcher) {
            return new TypeSafeDiagnosingMatcher<Band>() {
                @Override
                public void describeTo(Description description) {
                }

                @Override
                protected boolean matchesSafely(Band item, Description mismatchDescription) {
                    return matcher.matches(item.getMembers());
                }
            };

        }

        public static void main(String[] args) {
            Band band = new Band();
            assertThat(band, hasMembers(everyItem(equalTo(new Member())))); // works with signature Matcher<Iterable<Member>>
            assertThat(band, hasMembers(hasItem(equalTo(new Member()))));   // works with signature Matcher<Iterable<? super Member>>
            assertThat(band, hasMembers(contains(equalTo(new Member()))));  // works with signature Matcher<Iterable<? extends Member>>
        }
    }

2 个答案:

答案 0 :(得分:2)

以下签名对我有用:

public static Matcher<Band> hasMembers(final Matcher<? super Iterable<Member>> matcher) {
    // ...
}

旁注:

Hamcrest拥有FeatureMatcher类,可以轻松地为特定属性创建匹配器:

public static Matcher<Band> hasMembers(final Matcher<? super Iterable<Member>> matcher) {
    return new FeatureMatcher<Band, Iterable<Member>>(matcher, "a band with members", "members") {

        @Override
        protected Iterable<Member> featureValueOf(Band actual) {
            return actual.getMembers();
        }
    };
};

答案 1 :(得分:1)

非常棘手的问题。只能使它适用于前两个(everyItemhasItem

public static <M extends Member, B extends Band, I extends Iterable<? super M>> Matcher<B> hasMembers(
        final Matcher<I> matcher) {
    return new TypeSafeDiagnosingMatcher<B>() {
        @Override
        public void describeTo(Description description) {
        }

        @Override
        protected boolean matchesSafely(B item, Description mismatchDescription) {
            return matcher.matches(item.getMembers());
        }
    };
}