如果我尝试这段代码,我的网络应用程序的性能会降低吗?

时间:2015-08-18 17:19:10

标签: java connection-pooling apache-commons-dbcp

我创建“DataSourceConnection”类遵循Singleton Pattern,但我想连接到多数据库,所以我写了“getDataSource(String driver,String url,String username,String password)”函数,它将返回BasicDataSource变量。我将此变量保存到ServletContext的属性,当我需要连接到哪个数据库时,我从ServletContext中获取它。我应该尝试使用这个解决方案吗?

import java.io.Serializable;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;

import javax.sql.DataSource;

import org.apache.commons.dbcp2.BasicDataSource;

public class DataSourceConnection implements Cloneable, Serializable {

    private static final long serialVersionUID = 1L;

    private BasicDataSource dataSource;

    private static class DataSourceConnectionHolder {
        private static DataSourceConnection INSTANCE = new CustomerDataSourceConnection();
    }

    protected Object clone() throws CloneNotSupportedException {
        return new CloneNotSupportedException();
    }

    private DataSourceConnection() {
    }

    public static DataSourceConnection getInstance() {
        return DataSourceConnectionHolder.INSTANCE;
    }

    public DataSource getDataSource(String driver, String url, String username, String password) {
        dataSource = new BasicDataSource();
        dataSource.setDriverClassName(driver);
        dataSource.setUsername(username);
        dataSource.setPassword(password);
        return dataSource;
    }

    public Connection getConnection() throws SQLException {
        return dataSource.getConnection();
    }
}

1 个答案:

答案 0 :(得分:0)

此上下文中单例模式的目的是仅创建与数据库的单个连接(这是一个缓慢的操作),并在代码中重用该连接。

由于您想要连接到多个数据库,因此您需要一个" singleton"对于每个数据库。你不应该为此实现多个类,只需要一个具有多个静态"共享"连接。

除非getConnection()维护连接池,否则DataSource速度很慢。

更新了示例

public final class DataSourceConnection {
    // This defines an instance of the class
    private BasicDataSource dataSource;
    private DataSourceConnection(String driver, String url, String username, String password) {
        this.dataSource = new BasicDataSource();
        this.dataSource.setDriverClassName(driver);
        this.dataSource.setUrl(url);
        this.dataSource.setUsername(username);
        this.dataSource.setPassword(password);
    }
    public Connection getConnection() throws SQLException {
        return this.dataSource.getConnection();
    }
    // This defines the "shared"/"multiple singleton" instances
    public static final DataSourceConnection DATABASE1 = new DataSourceConnection("...", "...", "...", "...");
    public static final DataSourceConnection DATABASE2 = new DataSourceConnection("...", "...", "...", "...");
    public static final DataSourceConnection DATABASE3 = new DataSourceConnection("...", "...", "...", "...");
}

你会像这样使用它:

try (Connection conn = DataSourceConnection.DATABASE2.getConnection()) {
    // Access database #2 here
}

当然,实际上,您希望3个数据源的初始化基于某些配置文件,而不是像显示的那样进行硬编码。