为什么Eigen矩阵到C数组转换为前两个索引提供了垃圾值?

时间:2015-07-12 01:44:13

标签: c++ arrays eigen

我有一个特征矩阵要转换为C数组。我可以通过以下示例复制该问题。

#include <iostream>
#include <Eigen/Core>

int *test()
{
    Eigen::MatrixXi arr = Eigen::MatrixXi::Ones(6,1);
    // just to check
    arr(4)=3;
    arr(5)=19;
    return arr.data();
}

int main()
{
    int *c_arr;
    c_arr = test();

    for (int i=0; i<6;++i)
    {
        std::cout << c_arr[i] << std::endl;
    }

    return 0;
}

输出

0
0
1
1
3
19

现在,如果我从test函数中打印转换后的C数组值,则值是正确的。但是,如果我从main打印值(如上所示),前两个索引总是垃圾。所以我想知道函数调用中发生了什么?我用不同的特征矩阵(类型,大小)尝试了这个,我得到了相同的结果。

1 个答案:

答案 0 :(得分:1)

我首先要说的是我并不是100%熟悉Eigen库(只是出于好奇而下载它才能看到它)并且它的文档有点缺乏但是你的问题是一个基本的C问题,可以通过几种方式解决。

首先,我们首先解释代码中发生的事情,以提供垃圾值:

int *test()
{
    /* create an auto scoped variable on the stack;
       this variable is only "visible" to this function
       and any references to it or it's underlying data
       outside the scope of this function will result
       in "undefined behaviour" */
    Eigen::MatrixXi arr = Eigen::MatrixXi::Ones(6,1);
    arr(4)=3;
    arr(5)=19;
    /* arr.data() is defined as returning a pointer to the scalar underlying type (or
    a C-style array in other words). Regardless of the type being returned, it is pointer based
    and you are returning a pointer to a location in memory, not the actual data being held in
    the memory. */
    return arr.data();
} /* the variable arr is destroyed here since we left function scope and the return value (the pointer location)
is put in the return register and "program flow" is returned back to the main function where the pointer being
returned now points to "invalid" memory */

int main()
{
    int *c_arr; // create a pointer type that can reference int types
    c_arr = test(); // point it to the result of the test function (see notes above)
    /* c_arr now points to a memory location returned from test, but since the
    arr variable no longer exists here, when you go through and print the values pointed
    to at those memory locations you will get what is at those locations and could be "anything"
    except a valid reference to the original arr variable and it's underlying data. */

    for (int i=0; i<6;++i)
    {
        std::cout << c_arr[i] << std::endl;
    }

    return 0;
}

这就是为什么,至于如何修复它,有几种方法可以解决你的问题;一种是将返回数组作为变量传递给test函数(例如void test(int*& val)),然后可以选择在测试函数中为变量分配新内存,或者假设用户有已经这样做了,并且还必须假设用户将自行清理并致电delete[](不仅仅是delete,因为您正在对数据阵列进行操作)。

但是这有很多需要知道分配多少空间并确保在完成时释放的注意事项。我不确定为什么你特别需要一个C风格的数组但是因为你使用的是C ++,如果你使用一些可用的STL和容器函数来帮助你,可能会更谨慎,例如:

#include <iostream>
#include <vector>
#include <Eigen/Core>

std::vector<int> test()
{
    Eigen::MatrixXi arr = Eigen::MatrixXi::Ones(6,1);
    arr(4)=3;
    arr(5)=19;
    // we need the size so we know how big of a container to allocate
    std::size_t sz = arr.innerSize() * arr.outerSize();
    std::vector<int> ret(sz);
    // get a temporary C array pointer so we can reference the data
    int* tmp = arr.data();
    // copy from tmp[0] to tmp[sz] and insert the data into the first element of ret
    std::copy(tmp, tmp+sz, ret.begin());
    // return the (copied) data
    return ret;
}

int main()
{
    std::vector<int> c_arr = test();
    // c_arr now points to valid data it holds and can be iterated on
    for (std::size_t i = 0; i < c_arr.size(); ++i) {
        std::cout << c_arr[i] << std::endl;
    }
    // if you need a C-style array from here, you can easily copy the data
    // from the vector to your C-array
    return 0;
}

我研究过使用该类的cast()函数,但是不能完全弄清楚语法是否比上面那样复制它没有那么痛苦,因为它看起来像你不得不打电话将cast函数转换为不同的Eigen类型,然后从那里再次强制转换,但知道有一个cast函数和其他方法来获取MatrixX类的基础数据如果你需要访问它。

我希望可以提供帮助。