我想使用Kmett的lens library来访问特定键下的(键,值)列表的元素。换句话说,我想用更惯用的东西替换这个代码,也许更简短:
type Headers = [ (ByteString, ByteString) ]
headerLens ::
Functor f =>
ByteString ->
(Maybe ByteString -> f (Maybe ByteString)) ->
Headers ->
f Headers
headerLens header_name f headers
| old_header_value <- fetchHeader headers header_name = fmap
(\ new_header_value ->
replaceHeaderValue
headers
header_name
new_header_value
)
(f old_header_value )
支持函数的定义如下:
-- | Looks for a given header and returns the value, if any
fetchHeader :: Headers -> ByteString -> Maybe ByteString
fetchHeader headers header_name =
snd <$> find ( \ x -> fst x == header_name ) headers
-- | replaceHeaderValue headers header_name maybe_header_value looks for
-- header_name. If header_name is found and maybe_header_value is nothing, it
-- returns a new headers list with the header deleted. If header_name is found
-- and header_value is Just new_value, it returns a new list with the header
-- containing the new value. If header_name is not in headers and maybe_header_value
-- is Nothing, it returns the original headers list. If header_name is not in headers
-- and maybe_header_value is Just new_value, it returns a new list where the last element
-- is (header_name, new_value)
replaceHeaderValue :: Headers -> ByteString -> Maybe ByteString -> Headers
replaceHeaderValue headers header_name maybe_header_value =
disect id headers
where
disect builder [] = case maybe_header_value of
Nothing -> headers
Just new_value -> builder $ (header_name, new_value):[]
disect builder ( el@(hn,hv) : rest)
| hn /= header_name =
disect
(\ constructed_list -> builder $ el:constructed_list )
rest
| otherwise = case maybe_header_value of
Nothing -> builder rest
Just new_value -> builder $ (hn, new_value):rest
答案 0 :(得分:4)
好吧,如果您使用Data.Map.Map
作为您的结构(应该是一个非常简单的重构),您将不必自己复制所有这些工作:
import qualified Data.Map as M
import Control.Lens
type Headers = M.Map ByteString ByteString
fetchHeader :: Headers -> ByteString -> Maybe ByteString
fetchHeader = flip M.lookup
replaceHeaderValue :: Headers -> ByteString -> Maybe ByteString -> Headers
replaceHeaderValue headers header_name maybe_header_value
= M.alter (const maybe_header_value) header_name headers
然后你可以保持headerLens
原样。或者你可以看看像
headerLens name = lens (M.lookup name) (\hs mhv -> M.alter (const mhv) name hs)
根本不需要支持功能,并且可以使用非常通用的签名来处理更多类型的Map
。用法示例:
> let hs = M.fromList [("foo", "bar")]
> hs ^. headerLens "foo"
Just "bar"
> hs ^. headerLens "baz"
Nothing
> headerLens "foo" .~ Just "baz" $ hs
fromList [("foo", "baz")]
> headerLens "foo" .~ Nothing $ hs
fromList []
> headerLens "qux" .~ Just "baz" $ hs
fromList [("foo", "bar"), ("qux", "baz")]
> headerLens "qux" .~ Nothing $ hs
fromList [("foo", "bar")]
但是,这不会保留元素的顺序,这对您来说可能是个问题。那里可能有一个有序的地图,类似于Python的OrderedDict
,但我之前没有在Haskell中使用它。