执行ln -s命令的bash脚本在退出时获取错误代码,但正在成功创建符号链接

时间:2014-12-24 16:32:49

标签: linux bash ln

我编写了一个bash脚本,它应该通过TARGET DIR中的文件和目录进行迭代,并为DESTINATION DIR中的所有目录创建一个符号链接。该脚本可以工作,但是ln命令从我能告诉的内容中给出退出代码> 0,因此不会打印相应的成功消息。

在执行脚本之前,这里是目的地目录:

obi@Hanzomon:/home/dog⟫ ls -la
total 8
drwxr-xr-x 2 obi obi 4096 Dec 24 11:13 .
drwxr-xr-x 8 obi obi 4096 Dec 24 10:32 ..

这是一个目标明确的目录,有很少的副主任

obi@Hanzomon:/home/dog⟫ ls /home/bud
bzfs.conf  Downloads         Music     Templates  VirtualBox VMs
Desktop    examples.desktop  Pictures  vboxen     vmz
Documents  lab               Public    Videos

这是我跑的时候的输出:

obi@Hanzomon:/home/dog⟫ /home/obi/scripts/dirlink.sh                            
/home/bud/Desktop failed to link to /home/dog/Desktop
/home/bud/Documents failed to link to /home/dog/Documents
/home/bud/Downloads failed to link to /home/dog/Downloads
/home/bud/lab failed to link to /home/dog/lab
/home/bud/Music failed to link to /home/dog/Music
/home/bud/Pictures failed to link to /home/dog/Pictures
/home/bud/Public failed to link to /home/dog/Public
/home/bud/Templates failed to link to /home/dog/Templates
/home/bud/vboxen failed to link to /home/dog/vboxen
/home/bud/Videos failed to link to /home/dog/Videos
/home/bud/VirtualBox VMs failed to link to /home/dog/VirtualBox VMs
/home/bud/vmz failed to link to /home/dog/vmz

这是在加入SYMLINKS的SCRIPT运行后的目的地DIR。

obi@Hanzomon:/home/dog⟫ ls -la
total 8
drwxr-xr-x 2 obi obi 4096 Dec 24 11:13 .
drwxr-xr-x 8 obi obi 4096 Dec 24 10:32 ..
lrwxrwxrwx 1 obi obi   17 Dec 24 11:13 Desktop -> /home/bud/Desktop
lrwxrwxrwx 1 obi obi   19 Dec 24 11:13 Documents -> /home/bud/Documents
lrwxrwxrwx 1 obi obi   19 Dec 24 11:13 Downloads -> /home/bud/Downloads
lrwxrwxrwx 1 obi obi   13 Dec 24 11:13 lab -> /home/bud/lab
lrwxrwxrwx 1 obi obi   15 Dec 24 11:13 Music -> /home/bud/Music
lrwxrwxrwx 1 obi obi   18 Dec 24 11:13 Pictures -> /home/bud/Pictures
lrwxrwxrwx 1 obi obi   16 Dec 24 11:13 Public -> /home/bud/Public
lrwxrwxrwx 1 obi obi   19 Dec 24 11:13 Templates -> /home/bud/Templates
lrwxrwxrwx 1 obi obi   16 Dec 24 11:13 vboxen -> /home/bud/vboxen
lrwxrwxrwx 1 obi obi   16 Dec 24 11:13 Videos -> /home/bud/Videos
lrwxrwxrwx 1 obi obi   24 Dec 24 11:13 VirtualBox VMs -> /home/bud/VirtualBox VMs
lrwxrwxrwx 1 obi obi   13 Dec 24 11:13 vmz -> /home/bud/vmz

这是脚本本身:

#!/bin/bash

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

TARDIR="/home/bud"
DESTDIR="/home/dog"

if  [ ! -d $TARDIR ]; then
        printf "$TARDIR does not exist!\n"
        exit
fi

if [ ! -d $DESTDIR ]; then 
        printf "$DESTDIR does not exist!\n"
        exit
fi


TARDIR="$TARDIR/*"
for DIR in $TARDIR; do
        if [ -d $DIR ]; then
                printf "$DIR"
                TARG="$DESTDIR/$(basename "$DIR")"
                if [  $(ln -s "$DIR" "$TARG") ]; then
                        printf " ==>  $TARG\n"
                else
                        printf " failed to link to $TARG\n"
                fi
        fi

done

IFS=$SAVEIFS

所以,底线是脚本可以工作,但是[$(ln -s“$ DIR”“$ TARG”)]应该返回零,printf“==> $ TARG \ n”行应该打印一个成功消息,但相反,即使目标目录为空,我也会收到“消息”的失败链接。

有任何想法/建议吗?

谢谢!

1 个答案:

答案 0 :(得分:4)

这一行错了:

if [  $(ln -s "$DIR" "$TARG") ]; then

它正在测试ln是否生成任何输出,而不是它是否成功。将其更改为:

if ln -s "$DIR" "$TARG"; then

请删除冗余打印,养成向stderr写入错误消息的习惯,如果脚本失败则退出非零值。 (例如,printf 'this is an error' >&2; exit 1;