我正在尝试重构遍布各地的一行代码。我们正在使用EF6.1并希望找到手机和电子邮件(作为字符串)。
public SiteLabelDto[] GetVendorSites(int vendorId)
{
return Context.Sites.Where(s => !s.IsDeleted && s.Vendor.Id == vendorId)
.Select(s => new SiteLabelDto
{
Id = s.Id,
Name = s.Name,
Address = s.Address.StreetAddress + ", " + s.Address.Locality + ", " + s.Address.Region + ", " + s.Address.Postcode,
Country = s.Address.Country.Name,
Email = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Email) != null ? s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Email).Value : "",
Phone = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Phone) != null ? s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Phone).Value : "",
}).ToArray();
}
上面的代码采用了接触点列表,并尝试找到最适合每种类型的接触点。
public class ContactPointEntity
{
public int Id { get; set; }
public string Value { get; set; }
public ContactPointType Type { get; set; }
public bool IsDefault { get; set; }
}
该方法将扩展为尝试首先在第一个中返回IsDefault。
我的目标是尝试并将其放入方法或扩展中,以便我可以说s.GetcontactPoint(ContactPointType.Email)或s.contactPoints.GetPoints(ContactPointType.Email)并返回字符串值,或者如果字符串不是可能的情况,则返回一个contactpoint类。
我读的越多,我想我需要构建一些表达式树,不知道到底是什么。
答案 0 :(得分:2)
您需要构建表达式树。
首先,由于您需要引入IsDefault
条件,因此表达式可能如下所示:
s.ContactPoints
.Where(x => x.Type == ContactPointType.Email && x.IsDefault)
.Select(x => x.Value)
.DefaultIfEmpty(string.Empty)
.FirstOrDefault()
然后,将接触点选择器转换为表达式。
private static Expression<Func<Site, string>> GetContactPoint(ParameterExpression siteParam, ParameterExpression cpeParam, ContactPointType type)
{
// Where.
var typeCondition = Expression.Equal(Expression.Property(cpeParam, "Type"), Expression.Constant(type));
var defaultCondition = Expression.Equal(Expression.Property(cpeParam, "IsDefault"), Expression.Constant(true));
var condition = Expression.AndAlso(typeCondition, defaultCondition);
var predicateExp = Expression.Lambda<Func<ContactPointEntity, bool>>(condition, cpeParam);
var whereExp = Expression.Call(typeof(Enumerable), "Where", new[] { typeof(ContactPointEntity) }, Expression.Property(siteParam, "ContactPoints"), predicateExp);
// Select.
var valueExp = Expression.Lambda<Func<ContactPointEntity, string>>(Expression.Property(cpeParam, "Value"), cpeParam);
var selectExp = Expression.Call(typeof(Enumerable), "Select", new[] { typeof(ContactPointEntity), typeof(string) }, whereExp, valueExp);
// DefaultIfEmpty.
var defaultIfEmptyExp = Expression.Call(typeof(Enumerable), "DefaultIfEmpty", new[] { typeof(string) }, selectExp, Expression.Constant(string.Empty));
// FirstOrDefault.
var firstOrDefaultExp = Expression.Call(typeof(Enumerable), "FirstOrDefault", new[] { typeof(string) }, defaultIfEmptyExp);
var selector = Expression.Lambda<Func<Site, string>>(firstOrDefaultExp, siteParam);
return selector;
}
并创建网站标签dto选择器。
private static Expression<Func<Site, SiteLabelDto>> GetSite(ParameterExpression siteParam, ParameterExpression cpeParam)
{
var newExp = Expression.New(typeof(SiteLabelDto));
var initExp = Expression.MemberInit(
newExp,
Expression.Bind(typeof(SiteLabelDto).GetProperty("Id"), Expression.Lambda<Func<Site, int>>(Expression.Property(siteParam, "Id"), siteParam).Body),
Expression.Bind(typeof(SiteLabelDto).GetProperty("Name"), Expression.Lambda<Func<Site, string>>(Expression.Property(siteParam, "Name"), siteParam).Body),
/* other basic information */
Expression.Bind(typeof(SiteLabelDto).GetProperty("Email"), GetContactPoint(siteParam, cpeParam, ContactPointType.Email).Body),
Expression.Bind(typeof(SiteLabelDto).GetProperty("Phone"), GetContactPoint(siteParam, cpeParam, ContactPointType.Phone).Body)
/* other types */
);
var selector = Expression.Lambda<Func<Site, SiteLabelDto>>(initExp, siteParam);
return selector;
}
使用。
var siteParam = Expression.Parameter(typeof(Site), "s");
var cpeParam = Expression.Parameter(typeof(ContactPointEntity), "cpe");
var selector = GetSite(siteParam, cpeParam);
return Context.Sites
.Where(s => !s.IsDeleted && s.Vendor.Id == vendorId)
.Select(selector)
.ToArray();
PS:
上面的一些代码可能需要重构,这只是给出了如何做的基本想法。
<强>更新强>
您还可以创建一个包装类,以包含EF实例和所有联系点。
public class ContactPointExt<T>
{
public T Instance { get; set; }
public string Email { get; set; }
public string Phone { get; set; }
}
然后将GetSite
更改为GetContactPoints
,将结果返回为ContactPointExt<T>
。
private static Expression<Func<Site, ContactPointExt<T>>> GetContactPoints<T>(ParameterExpression siteParam, ParameterExpression cpeParam)
{
var type = typeof(ContactPointExt<T>);
var newExp = Expression.New(type);
var initExp = Expression.MemberInit(
newExp,
Expression.Bind(type.GetProperty("Instance"), siteParam),
Expression.Bind(type.GetProperty("Email"), GetContactPoint(siteParam, cpeParam, ContactPointType.Email).Body),
Expression.Bind(type.GetProperty("Phone"), GetContactPoint(siteParam, cpeParam, ContactPointType.Phone).Body)
);
var selector = Expression.Lambda<Func<Site, ContactPointExt<T>>>(initExp, siteParam);
return selector;
}
ContactPointExt<T>
的结果可以使用其他SiteLabelDto
重新投放到Select
。
var siteParam = Expression.Parameter(typeof(Site), "s");
var cpeParam = Expression.Parameter(typeof(ContactPointEntity), "cpe");
var selector = GetContactPoints<Site>(siteParam, cpeParam);
return Context.Sites
.Where(s => !s.IsDeleted && s.Vendor.Id == vendorId)
.Select(selector)
.Select(s => new SiteLabelDto
{
Id = s.Instance.Id,
Name = s.Instance.Name,
Email = s.Email,
Phone = s.Phone
})
.ToArray();
来自OP的编辑
我们创建了一个包装器方法,使重用更加简单,只是为了向其他人展示:
/// <summary>
/// Wraps up a each of a query's objects in a ContactPointExt<T> object, providing the default contact point of each type.
/// The original query object is accessed via the "Instance" property on each result.
/// Assumes that the query object type has a property called ContactPoints - if different, supply the property name as the first argument.
/// </summary>
/// <typeparam name="T"></typeparam>
/// <param name="query"></param>
/// <param name="contactPointsPropertyName"></param>
/// <returns></returns>
public static IQueryable<ContactPointExt<T>> WithContactPointProcessing<T>(this IQueryable<T> query, string contactPointsPropertyName = "ContactPoints") where T : class
{
var siteParam = Expression.Parameter(typeof(T), "s");
var cpeParam = Expression.Parameter(typeof(ContactPointEntity), "cpe");
var selector = ContactPointHelpers.GetContactPoints<T>(siteParam, cpeParam, contactPointsPropertyName);
return query.Select(selector);
}
答案 1 :(得分:0)
使用Linq-to-entites的扩展方法有点棘手,因为并非所有提供商都能理解并转换为相应的后端调用。一个相对更安全的赌注是取IQueryable
并返回它可以解决的IQueryable
:
public static IQueryable<SiteDTO> MapToSiteDTO(this IQueryable<Site> query)
{
return query.Select(s => new SiteLabelDto
{
Id = s.Id,
Name = s.Name,
Address = s.Address.StreetAddress + ", " + s.Address.Locality + ", " + s.Address.Region + ", " + s.Address.Postcode,
Country = s.Address.Country.Name,
Email = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Email) != null ? s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Email).Value : "",
Phone = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Phone) != null ? s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Phone).Value : "",
});
}
然后你称之为:
return Context.Sites.Where(s => !s.IsDeleted && s.Vendor.Id == vendorId)
.Select(x => x)
.MapToSiteDTO()
.ToArray();
答案 2 :(得分:0)
public SiteLabelDto[] GetVendorSites(int vendorId)
{
return (from s in Context.Sites
where !s.IsDeleted && s.Vendor.Id == vendorId
let email = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Email)
let phone = s.ContactPoints.FirstOrDefault(x => x.Type == ContactPointType.Phone)
select new SiteLabelDto
{
Id = s.Id,
Name = s.Name,
Address = s.Address.StreetAddress + ", " + s.Address.Locality + ", " + s.Address.Region + ", " + s.Address.Postcode,
Country = s.Address.Country.Name,
Email = email != null ? email.Value : "",
Phone = phone != null ? phone .Value : "",
}).ToArray();
}