正在释放的指针未被分配，动态数组C ++

Question

我有a similar issue with C，但我现在的问题实际上是more similar to this.

不幸的是，我只是在学习C ++，我看不出如何将解决方案应用到我以前的问题（如果确实适用），而后一篇文章是他的代码的一个特定问题，那就更多了比我自己复杂。

以下是相关代码：

double n1, n2; //temporary data for user entry
int pcount = 0; //size of my array
struct point{double x; double y;};
point *p = new point[1]; //my array
point *tmp;  //temporary array while resizing

while (points >> n1 >> n2){ //for each element the user enters, 
    pcount++; //increase the array size
    tmp = new point[pcount]; //allocate new memory for the array
    tmp = p; //copy the elements from the old to the temporary
    delete [] p; //delete the old array
    p = new point[pcount]; //allocate memory for the new array
    p = tmp; //copy the elements from the temporary to the new array
    delete [] tmp; //delete the temporary
    p[pcount-1].x = n1; //now push back the new element
    p[pcount-1].y = n2;
}

如您所见，p和tmp指向具有初始大小的数组，并且在几行内被释放。至关重要的是，我看不出“释放的指针是如何分配的” - p在声明中分配，tmp在循环内，然后p被释放并重新分配，然后{{1释放，所以循环继续......

我也试过通过两个循环实现，但是打印的“点”是tmp，无论它们实际是什么 - 我都找不到原因？

(0, 0)

Answer 1

这里几乎每一行都有一个错误：

point *p = new point[1]; // Allocation #1
tmp = new point[pcount]; // Allocation #2
tmp = p;                 // Allocation #2 lost (memory leak)
delete [] p;             // Now 'tmp' is "pointing to junk"
p = new point[pcount];   // Allocation #3
p = tmp;                 // Allocation #3 lost (memory leak), and 'p' is "pointing to junk"
delete [] tmp;           // Segmentation fault, since 'tmp' is "pointing to junk"
p[pcount-1].x = n1;      // Segmentation fault, since 'p' is "pointing to junk"
p[pcount-1].y = n2;      // Segmentation fault, since 'p' is "pointing to junk"

Answer 2

你似乎误解了指针是如何工作的。 tmp在循环的第二行中被赋予一个新的point []，但是在第三行中，tmp被另一个值覆盖，销毁对刚分配的内存的任何引用...这会导致内存泄漏。我知道，这不是你的问题，但我认为你应该考虑整件事......