Question

Private Sub CommandButton1_Click()
Dim selection As Variant
selection = UserForm1.ComboBox1.Text
Sheets("Sheet1").Select
Cells(1, 2) = selection
Sheets("Sheet1").Select
selection = Cells(1, 2)
namefile = "C:\Users\xxx\" & Left(selection, 1) & "\" & selection & ".xls"
Workbooks.Open Filename:=namefile



Dim wk1 As Workbook
Dim wk2 As Workbook
Dim sh1 As Worksheet
Dim sh2 As Worksheet



Set wk1 = Workbooks("file1.xlsm")
Set wk2 = Workbooks(selection & ".xls")

Set sh1 = wk1.Worksheets("Sheet2")
Set sh2 = wk2.Worksheets("Sheet1")

sh2.Activate
Dim firstempty As Variant
Dim x As Integer
Dim y As Integer
Dim A1 As Variant
Dim R1 As Variant
Dim C1 As Variant
x = 0
y = 0
While x = 0
If Range(Cells(1, y), Cells(1, y)) <> "" Then
y = y + 1
Else: Range(Cells(1, y), Cells(1, y)).Select
A1 = Target.Address
R1 = Target.Row
C1 = Replace(A1, R1, "")
firstempty = (C1 & ":" & C1)
x = 1
End If
Wend

With sh1

    .Columns("D:D").Copy Destination:=sh2.Range(firstempty)
End With


End
End Sub

我需要在第二个文件的sheet1的第一个空白列上复制Sheet2 file1.xls的D列，该文件的名称由组合框选择。我无法定义第二个文件的空列的字母。我收到运行时错误424，我的调试器让我到了代码的关键点： A1 = Target.Address

我做错了什么？

Answer 1

y = 0时不应该是y = 0吗？现在你指的是第0列。

然后这应该有效：

If Cells(1, y) <> "" Then
y = y + 1
Else
firstempty = y
x = 1
End If

然后：

.Columns("D:D").Copy Destination:=sh2.Columns(firstempty)

Answer 2

以下是获取最后一列的更快捷的方法：

Private Sub CommandButton1_Click()
Dim selection As Variant
selection = UserForm1.ComboBox1.Text
Sheets("Sheet1").Select
Cells(1, 2) = selection
Sheets("Sheet1").Select
selection = Cells(1, 2)
namefile = "C:\Users\xxx\" & Left(selection, 1) & "\" & selection & ".xls"
Workbooks.Open Filename:=namefile



Dim wk1 As Workbook
Dim wk2 As Workbook
Dim sh1 As Worksheet
Dim sh2 As Worksheet



Set wk1 = Workbooks("file1.xlsm")
Set wk2 = Workbooks(selection & ".xls")

Set sh1 = wk1.Worksheets("Sheet2")
Set sh2 = wk2.Worksheets("Sheet1")

Dim LastColumn As Long

LastColumn = sh2.Cells(1, Columns.Count).End(xlToLeft).Column + 1

sh1.Columns("D:D").Copy sh2.Cells(, LastColumn)

End Sub

作为附注，您可以解释这部分代码：

Sheets("Sheet1").Select
Cells(1, 2) = selection
Sheets("Sheet1").Select
selection = Cells(1, 2)

看起来您正在获取一个值，然后将值分配给单元格，然后将单元格值（您刚刚分配的值）返回给分配原始值的变量。

最多只需要一行：

Sheets("Sheet1").Cells(1, 2) = selection

不需要休息。

VBA将列从excel文件复制到第一个空列中的另一列

2 个答案: