Question

我正在制作一个程序来洗牌一副牌并交出两只手，但是现在，没有输出！我梳理了无限循环的代码，但我找不到任何东西！有人可以帮助我吗？

// (Description in Word File)
#include <iostream>
#include <cstdlib>
#include <ctime>
#include <string>
using namespace std;

unsigned seed = time(0); // for use of rand()

const int SUIT = 4;
const int FACE = 13;
const int HAND = 5;

// A couple of reference arrays.
const string SUITS[SUIT] = {" Hearts", " Diamonds", " Clubs", " Spades"};
const string FACES[FACE] = {"Ace of", "Two of", "Three of",
                            "Four of", "Five of", "Six of", "Seven of",
                            "Eight of", "Nine of", "Ten of",
                            "Jack of", "Queen of", "King of"};

// The reason that these functions are in Main is because
// it gives me error 2065: undeclared identifier otherwise.
void shuffle(string[][FACE]);
void deal(string[][FACE], string[HAND]);
void displayDeck(string[][FACE]);
void displayHand(string[HAND]);

int main()
{
    string deck[SUIT][FACE];
    string hand1[HAND];
    string hand2[HAND];

    srand(seed); // for use of rand()

    // Shuffle the deck.
    shuffle(deck);

        // Now display the deck
    displayDeck(deck);

    // Deal for each hand.
    deal(deck, hand1);
    deal(deck, hand2);

    // Now display each hand.
    displayHand(hand1);
    displayHand(hand2);

    return 0;
}

// This function will keep track of face values
// for the shuffle function
bool duplCheck(string cards[][FACE], int suit, int face)
{
    bool status = true;
    for (int count1 = 0; count1 != SUIT; count1++)
        for (int count2 = 0; count2 != FACE; count2++)
            if (cards[count1][count2] == cards[suit][face]
                && suit != count1 && face != count2)
                return false;
    return status;
}

// This function will shuffle the deck.
void shuffle(string cards[][FACE])
{
    int randFace, randSuit;
    // These loops will assign random face values
    // and suits to each place in cards[][].
    for (int count1 = 0; count1 != SUIT; count1++)
        for (int count2 = 0; count2 != FACE; count2++)  
        {
            do
            {
                randFace = rand() % FACE;
                randSuit = rand() % SUIT;
                if (duplCheck(cards, randSuit, randFace) == true)
                    cards[count1][count2] = 
                        FACES[randFace] + SUITS[randSuit];
            } while(duplCheck(cards, randSuit, randFace) == false);
        }
}

// This function deals out a hand of five random cards.
void deal(string cards[][FACE], string hand[HAND])
{
    for (int count = 0; count != HAND; count++)
    {
        // make random suit and face numbers
        int randSuit = rand() % SUIT;
        int randFace = rand() % FACE;

        // If random card is not obsolete...
        if (cards[randSuit][randFace] != "null")
            // ...assign that card to hand.
            hand[count] = cards[randSuit][randFace];

        // obsolete that card
        cards[randSuit][randFace] = "null";
    }
}

void displayDeck(string cards[][FACE])
{
    std::cout << "\t\tThe Deck:\n\n";
    for (int count1 = 0; count1 != SUIT; count1++)
        for (int count2 = 0; count2 != FACE; count2++)
        {
            std::cout << ((count1 * FACE) + count2 + 1) << " "
                << cards[count1][count2] << endl;
        }
}

void displayHand(string hand[HAND])
{

}

Answer 1

你的问题是洗牌，特别是在使用duplCheck时。

void shuffle(string cards[][FACE])
{
    int randFace, randSuit;
    // These loops will assign random face values
    // and suits to each place in cards[][].
    for (int count1 = 0; count1 != SUIT; count1++)
        for (int count2 = 0; count2 != FACE; count2++)  
        {
            do
            {
                randFace = rand() % FACE;
                randSuit = rand() % SUIT;
                std::cout << count1 << "," << count2 << " trying " << randFace << "/" << randSuit << std::endl;
                if (duplCheck(cards, randSuit, randFace) == true) {
                    std::cout << "duplCheck returned true" << std::endl;
                    cards[count1][count2] = 
                        FACES[randFace] + SUITS[randSuit];
                }
            } while(duplCheck(cards, randSuit, randFace) == false);
        }
}

我添加了一些额外的输出。这表明（http://ideone.com/BkZKD9）duplCheck在您第一次运行时没有返回false。

do
{
    randFace = rand() % FACE;
    randSuit = rand() % SUIT;
    if (duplCheck(cards, randSuit, randFace) == true) {
               ... this doesn't happen
    }
} while(duplCheck(cards, randSuit, randFace) == false);

因为duplCheck返回false，所以你永久保持在这个循环中。

bool duplCheck(string cards[][FACE], int suit, int face)
{
    bool status = true;
    for (int count1 = 0; count1 != SUIT; count1++)
        for (int count2 = 0; count2 != FACE; count2++)
            if (cards[count1][count2] == cards[suit][face]
                && suit != count1 && face != count2)
                return false;
    return status;
}

如果有重复，duplCheck似乎返回“false”，如果没有则返回“true”，但是你对它的使用期望相反：当duplCheck返回true时你的while循环停止，它希望duplCheck返回true如果有重复。

Answer 2

你的显示手功能是空的。

void displayHand(string hand[HAND])
{
    cout << "Put some output here";
}

Answer 3

问题是你的套牌最初是以空（“”）值开头的。您可以在调用shuffle（）之前在开始时填写此函数，也可以将此检查添加到duplCheck（）的开头：

if(cards[suit][face].length() == 0)
   return true;

程序中没有输出？

3 个答案: