Question

如何摆脱if conditional中的重复？

def set_caption(result)
  if result.respond_to?(:app_name)
    content_tag(:div, result.type_name, class: 'type-name') + 
      content_tag(:div, result.app_name, class: 'app-name')
  else
    content_tag(:div, result.type_name, class: 'type-name')
  end
end

Answer 1

这对你有用吗？

def set_caption(result)
  rv = content_tag(:div, result.type_name, class: 'type-name')
  if result.respond_to?(:app_name)
    rv += content_tag(:div, result.app_name, class: 'app-name')
  end
  rv
end

Answer 2

def set_caption(result)
  [:type_name, *(:app_name if result.respond_to?(:app_name))]
  .map{|name| content_tag(:div, result.send(name), class: name.hyphenize)}
  .inject(:+)
end

或者，假设result.respond_to?(:type_name)始终为真：

def set_caption(result)
  [:type_name, :app_name]
  .map{|name| if result.respond_to?(name)
    content_tag(:div, result.send(name), class: name.hyphenize)
  end}.compact.inject(:+)
end

如何正确返回一个或两个合并的content_tags？

2 个答案: