我应该帮帮忙吗?或者这会变慢吗?

时间:2013-01-20 21:14:53

标签: ruby-on-rails ruby-on-rails-3

在这种情况下哪种模式会更快?
显然,带帮手的Pattern1看起来更复杂,看起来很干净 但是每次调用user_link方法时它都会发送SQL 在这里,它在一页加载时调用最多100次。

哪种方式对基准性能更好?

型式1。有助手

application_helper

def user_link(username)
    link_to User.find_by_username(username).user_profile.nickname, show_user_path(username)
end

视图

<% @topics.order("updated_at DESC").limit(100).each do |topic| %>
    <%= user_link(topic.comment_threads.order("id").last.user.username) if topic.comment_threads.present? %>
<% end %>

PATTERN2。没有帮手。只是查看

<% @topics.order("updated_at DESC").limit(100).each do |topic| %>
    <%= link_to(topic.comment_threads.order("id").last.user.nickname, show_user_path(topic.comment_threads.order("id").last.user.username) ) if topic.comment_threads.present? %>
<% end %>

1 个答案:

答案 0 :(得分:1)

# Topics model
#via scope
scope :get_topic_list, lambda do
  order("updated_at DESC").joins(:comment_threads => :user).limit(100)
end

#via method
def self.get_topic_list
  Topic.order("updated_at DESC").joins(:comment_threads => :user).limit(100)
end

# in your controller or move to model itself (recommened)
@topics = Topic.get_topic_list

# in you view
<% @topics.each do |topic| %>
    <%= link_to(topic.comment_threads.order("id").last.user.nickname, show_user_path(topic.comment_threads.order("id").last.user.username) ) if topic.comment_threads.present? %>
<% end %>