C ++数组故障

时间:2012-02-17 22:05:52

标签: c++ arrays

我正在尝试构建一个tic tac toe游戏,并且由于某些原因,当我尝试将值放入任何值时,似乎被某个bug击中,它似乎给出了所选的角色(比如它的玩家1,和因此,'X'),进入用户选择的值(他想要的地方),但也烦恼地进入阵列的[1] [2]和[2] [0]。代码已附上。

#include "stdafx.h"
#include <iostream>
#include <string>
#include <ctime>
#include <cstdlib>

using namespace System;
using namespace std;

string game_board[2][2];
bool exit_condition = false;
int x_coords;
int y_coords;
int current_player;
string cp_char;

int returnxwin();
int returnowin();

int main()
{
    cout << "Welcome to Tic-Tac-Toe Console!\n" << endl;

    //Start of game
    while(exit_condition != true){
        cout << "This is the game board: " << endl;
        cout << " - | 1 | 2 | 3 | " << endl;
        cout << " 1 | " << game_board[0][0] <<" | " <<game_board[1][0] << " | " << game_board[2][0] << " | " <<endl;
        cout << " 2 | " << game_board[0][1] <<" | " <<game_board[1][1] << " | " << game_board[2][1] << " | "<<endl;
        cout << " 3 | " << game_board[0][2] <<" | " <<game_board[1][2] << " | " << game_board[2][2] << " | \n"<<endl;

        //TESTING PURPOSES BE SURE TO REMOVE!
        current_player = 1;

        //Says which player is first
        cout << "Player " << current_player << " is first!" << endl;

        //Determines which player is first, and if so, which character to give to them.
        if(current_player == 1)
        {
            cp_char = "X";
        } else if(current_player == 2) 
        {
            cp_char = "Y";
        }

        bool valid_input = false;

        while(valid_input != true){
            cout << "Where would you like to place your " << cp_char << " ? (X co-ordinates(top row))\n" ;
            cin >> x_coords;
            cout << "Where would you like to place your " << cp_char << " ? (Y co-ordinates(side row))\n" ;
            cin >> y_coords;

            if((x_coords <= 3) && (y_coords <=3))
            {
                if(game_board[x_coords-1][y_coords-1] == "")
                {
                    game_board[1][2] = "";
                    game_board[2][0] = "";
                    //Problem Here!
                    game_board[x_coords-1][y_coords-1] = cp_char;
                    break;
                    valid_input = true;
                }
                else
                {
                    cout << "Invalid Input! Somebody has already taken the slot!" << endl;
                }
            }
            else
            {
                cout << "Invalid input! Please enter a number from 1 to 3" << endl;
            }
        }
        //End of Valid Input Loop

        //make sure to remove break; 
        // break;
    }

    system("pause");
    return 0;
}

我还没有完成游戏,但却不知道为什么会发生这种情况:s

另一方面,我也在寻找一种方法来随机决定玩家1或2是否先行。

编辑:我按照建议尝试[3] [3],但它仍然给我一个错误。想法?

2 个答案:

答案 0 :(得分:2)

game_board被定义为2x2字符串的数组,它应该是3x3吗?

string game_board[3][3]

我猜你正在越过数组,所以你得到了未定义的结果..

关于有办法随机选择哪个玩家将开始使用rand()功能:

srand(time(NULL)); // to initialize the random sequence

current_player = rand()%2 + 1; //player will be either 1 or 2

答案 1 :(得分:2)

string game_board[2][2];

这将分配一个游戏板2个条目宽2个条目高。这比USTTTA / IOCTTT小 - 认可的锦标赛游戏板小一个。试试这个:

std::string game_board[3][3];