抛出所有goroutines都睡着了 - 僵局! -------谷歌GO的错误

时间:2011-11-25 18:00:03

标签: go concurrent-programming goroutine

我想写三个并发的例程,它们相互发送整数。现在,我的代码编译正确,但是在第一次执行后它会出现错误“throw:all goroutines is sleep - deadlock!”。我试图找到错误,但我无法在代码逻辑中找到任何错误。任何人都可以帮我找到我的代码的错误。我的代码如下。

package main

import "rand"

func Routine1(command12 chan int, response12 chan int, command13 chan int, response13 chan int) {

    // z12 is a variable which stores the value comming from channel 2 and z13 is a variable which stores the value comming from channel 3.

    z12 := 200
    z13 := 200
    m12 := false
    m13 := false
    y := 0

    for i := 0; i < 20; i++ {
        y = rand.Intn(100)

        // If y's value is not 0 then the value will be sent to routine 2 or 3 according to   prime or not.
        // If y's value is 0 then process state (the varibles used by it means z12, z13) and channel state will be saved.[routine 1 is initiator]

        if y == 0 {
            print(z12, "    z12 STATE SAVED\n")
            print(z13, "    z13 STATE SAVED\n")

            // Routine 1 is initiator,  it sends 0 to make other process to save the state.

            y = 0
            command12 <- y
            command13 <- y

            // Untill routine 2 and 3 does not send 0, process 1 is on channel saving state (it's process state is already saved).
            // When routine 1 recives 0 from both other processes, channel is saved and routine 1 retuns to it's common routine procedure.
            // When routine 1 recives 0 from any other processes, saving channel bettwen them is stopped.
            // m12, m13 is used to mark whether 0 recived or not.

            for m12 != true || m13 != true {
                select {
                case cmd1 := <-response12:
                    {
                        z12 = cmd1
                        if z12 != 0 {
                            print(z12, "    z12  Channel Saving.... \n")
                            y = rand.Intn(100)
                            command12 <- y
                        }
                        if z12 == 0 {
                            m12 = true
                            print(" z12  Channel Saving Stopped \n")
                        }
                    }

                case cmd2 := <-response13:
                    {
                        z13 = cmd2
                        if z13 != 0 {
                            print(z13, "    z13  Channel Saving.... \n")
                            y = rand.Intn(100)
                            command13 <- y
                        }
                        if z13 == 0 {
                            m13 = true
                            print("    z13  Channel Saving Stopped \n")
                        }
                    }
                }

            }

            // After saving process state it retuns to it's normal behaviour.

            m12 = false
            m13 = false
        }

        if y != 0 {

            // If y value is not 0, routine 1 just sends int to other process according to prime or not and recives int accordingly.

            if y%2 == 0 {
                command12 <- y
            }

            if y%2 != 0 {
                command13 <- y
            }
            select {
            case cmd1 := <-response12:
                {
                    z12 = cmd1
                    print(z12, "    z12\n")
                }
            case cmd2 := <-response13:
                {
                    z13 = cmd2
                    print(z13, "   z13\n")
                }
            }
        }
    }
    close(command12)
    close(command13)
}


//Routine 2 (or 3) is not an initiator (means it can't send 0). When it recives 0 (from routine 1 or 3) it save the state of process and the state of the channel from which it recived).
// When it recives 0 from both other two routine, it saves all channel state and returns to it's common behaviour. [same in routine 3]

func Routine2(command12 chan int, response12 chan int, command23 chan int, response23 chan int) {
    z21 := 200
    z23 := 200
    m21 := false
    m23 := false

    for i := 0; i < 20; i++ {
        select {
        case x, open := <-command12:
            {
                if !open {
                    return
                }
                if x != 0 && m23 != true {
                    z21 = x
                    print(z21, "   z21\n")
                }
                if x != 0 && m23 == true {
                    z21 = x
                    print(z21, "   z21 Channel Saving \n")
                }
                if x == 0 {
                    m21 = true
                    if m21 == true && m23 == true {
                        print(" z21 and z23 Channel Saving Stopped \n")
                        m23 = false
                        m21 = false
                    }
                    if m21 == true && m23 != true {
                        z21 = x
                        print(z21, "   z21  Channel Saved \n")

                    }

                }
            }

        case x, open := <-response23:
            {
                if !open {
                    return
                }
                if x != 0 && m21 != true {
                    z23 = x
                    print(z23, "   z21\n")
                }
                if x != 0 && m21 == true {
                    z23 = x
                    print(z23, "   z23 Channel Saving \n")
                }
                if x == 0 {
                    m23 = true
                    if m21 == true && m23 == true {
                        print(" z23 Channel Saving Stopped \n")
                        m23 = false
                        m21 = false
                    }
                    if m23 == true && m21 != true {
                        z23 = x
                        print(z23, "   z23  Channel Saved \n")
                    }

                }
            }
        }

        if m23 == false && m21 == false {
            y := rand.Intn(100)
            if y%2 == 0 {
                if y == 0 {
                    y = 10
                    response12 <- y
                }
            }

            if y%2 != 0 {
                if y == 0 {
                    y = 10
                    response23 <- y
                }
            }
        }

        if m23 == true && m21 != true {
            y := rand.Intn(100)
            response12 <- y
        }

        if m23 != true && m21 == true {
            y := rand.Intn(100)
            command23 <- y
        }

    }
    close(response12)
    close(command23)
}

func Routine3(command13 chan int, response13 chan int, command23 chan int, response23 chan int) {
    z31 := 200
    z32 := 200
    m31 := false
    m32 := false

    for i := 0; i < 20; i++ {
        select {
        case x, open := <-command13:
            {
                if !open {
                    return
                }
                if x != 0 && m32 != true {
                    z31 = x
                    print(z31, "   z21\n")
                }
                if x != 0 && m32 == true {
                    z31 = x
                    print(z31, "   z31 Channel Saving \n")
                }
                if x == 0 {
                    m31 = true
                    if m31 == true && m32 == true {
                        print(" z21 Channel Saving Stopped \n")
                        m31 = false
                        m32 = false
                    }
                    if m31 == true && m32 != true {
                        z31 = x
                        print(z31, "   z31  Channel Saved \n")

                    }

                }
            }

        case x, open := <-command23:
            {
                if !open {
                    return
                }
                if x != 0 && m31 != true {
                    z32 = x
                    print(z32, "   z32\n")
                }
                if x != 0 && m31 == true {
                    z32 = x
                    print(z32, "   z32 Channel Saving \n")
                }
                if x == 0 {
                    m32 = true
                    if m31 == true && m32 == true {
                        print(" z32 Channel Saving Stopped \n")
                        m31 = false
                        m32 = false
                    }
                    if m32 == true && m31 != true {
                        z32 = x
                        print(z32, "   z32  Channel Saved \n")

                    }

                }
            }
        }
        if m31 == false && m32 == false {
            y := rand.Intn(100)
            if y%2 == 0 {
                response13 <- y
            }

            if y%2 != 0 {
                response23 <- y
            }
        }

        if m31 == true && m32 != true {
            y := rand.Intn(100)
            response13 <- y
        }

        if m31 != true && m32 == true {
            y := rand.Intn(100)
            response23 <- y
        }

    }
    close(response13)
    close(response23)
}


func main() {

    // Three concurrent channels are created to pass integers to each other.
    // command 12 used to send int and response12 is used to receive int from routine 1 to routine 2.
    // response 12 used to send int and command 12 is used to receive int from routine 2 to routine 1. {so as for others}

    command12 := make(chan int)
    response12 := make(chan int)
    command13 := make(chan int)
    response13 := make(chan int)
    command23 := make(chan int)
    response23 := make(chan int)

    go Routine1(command12, response12, command13, response13)
    go Routine2(command12, response12, command23, response23)
    Routine3(command13, response13, command23, response23)
}

2 个答案:

答案 0 :(得分:3)

正如其他人所说 - 你的代码太复杂,我无法快速找到其预期的逻辑。无论如何,&#34;技术分析&#34;方法带来了一点点。将Gosched作为默认情况添加到选择语句使通道缓冲 - 然后代码不再死锁。虽然我不知道它在做什么以及它是否做了你想做的事。

在我看来,从查看代码来看,行为是非确定性的(?)。在任何情况下,我认为原始代码可能已被设计破坏(例如,一些循环看起来像他们正忙着等待,即使他们运行硬编码N次,sic!),很遗憾地说。

&#34;工作&#34; (==谁知道它在做什么)代码:http://play.golang.org/p/dcUpeJ9EUa

PS:缓冲区大小const @ line 325不能低于4(通过每周试运行),似乎提供了另一种改变代码行为的方法。

答案 1 :(得分:1)

我不知道你的问题的答案,但是switch中的Routine3语句看起来很麻烦,因为它包含两个相同的case语句(这让我想知道为什么6g不会抱怨这段代码。)

一些使您的代码更易读的建议:

  • 正如Evan已经指出的那样,尝试为变量提供更多描述性名称。阅读if someConditionIsMet的代码比if m23 == false更容易理解。
  • 通过将公共部分分解为函数来干燥代码。
  • 删除死代码,例如将布尔值设置为true,然后检查它是否为真或检查奇数是否等于零。
  • 考虑使用else代替if <condition> {...}; if <negated condition> {...}

我建议尝试进行单元测试,详尽地描述函数的预期行为。这不仅可以帮助您找到错误,还可以提高您的编码技能。根据我的经验,用测试编写的代码通常比未经测试的代码更容易理解,维护和发展。

快乐的黑客攻击:)