指数数组的边界之外?

时间:2018-05-16 07:28:53

标签: c# arrays exception try-catch

我不断收到此消息“System.IndexOutOfRangeException:Index超出了数组的范围。”当我试图运行我构建的程序时,它使用了异常捕获程序。

班级学生     {         private列出theStudentList;

    public bool PopulateStudents(string path)
    {
        theStudentList = new List<Student>();
        bool flag = false;
        try
        {
            List<string[]> strArrayList = new List<string[]>();
            using (StreamReader streamReader = new StreamReader(path))
            {
                string str;
                while ((str = streamReader.ReadLine()) != null)
                {
                    string[] strArray = str.Split(',');
                    strArrayList.Add(strArray);
                }
            }
            for (int index1 = 0; index1 < strArrayList.Count; ++index1)
            {
                string[] strArray = strArrayList[index1];
                Student student = new Student(strArray[0], strArray[1], strArray[2]); **where the error is**
                int index2 = 3;
                while (index2 < strArray.Length)
                {
                    student.EnterGrade(int.Parse(strArray[index2]), int.Parse(strArray[index2 + 1]));
                    index2 += 2;
                }
                student.CalGrade();
                theStudentList.Add(student);
            }
        }
        catch (Exception e)
        {
            flag = true;
            Console.WriteLine(e);
        }
        return flag;
    }

    public int ListLength
    {
        get
        {
            return theStudentList.Count;
        }
    }

    public float StudentAverage(int index)
    {
        return theStudentList.ElementAt(index).Average;
    }

    public string StudentGrade(int index)
    {
        return theStudentList.ElementAt(index).LetterGrade;
    }

    public string StudentID(int index)
    {
        return theStudentList.ElementAt(index).ID;
    }

    public string StudentLastName(int index)
    {
        return theStudentList.ElementAt(index).NameLast;
    }
}

class Student
{
    private float average;
    private ArrayList Earned;
    private string letterGrade;
    private string nameFirst;
    private string nameLast;
    private ArrayList Possible;
    private string studentID;

    public Student(string id)
    {
        studentID = null;
        nameFirst = null;
        nameLast = null;
        Earned = new ArrayList();
        Possible = new ArrayList();
    }

    public Student(string id, string first)
    {
        studentID = id;
        nameFirst = null;
        nameLast = null;
        Earned = new ArrayList();
        Possible = new ArrayList();
    }

    public Student(string id, string first, string last)
    {
        nameFirst = first;
        nameLast = last;
        studentID = id;
        Earned = new ArrayList();
        Possible = new ArrayList();
    }

    public float Average
    {
        get
        {
            return average;
        }
    }

    public string ID
    {
        get
        {
            return studentID;
        }
    }

    public string LetterGrade
    {
        get
        {
            return letterGrade;
        }
    }

    public string NameFirst
    {
        get
        {
            return nameFirst;
        }
        set
        {
            nameFirst = value;
        }
    }

    public string NameLast
    {
        get
        {
            return nameLast;
        }
        set
        {
            nameLast = value;
        }
    }

    public void CalGrade()
    {
        int num1 = 0;
        int num2 = 0;
        foreach (int num3 in Earned)
            num1 += num3;
        foreach (int num3 in Possible)
            num2 += num3;
        average = num1 / (float)num2;
        average = (float)Math.Round(average, 2);
        if (average >= 0.9)
            letterGrade = "A";
        if (average >= 0.8 && average < 0.9)
            letterGrade = "B";
        if (average >= 0.7 && average < 0.8)
            letterGrade = "C";
        if (average >= 0.6 && average < 0.7)
            letterGrade = "D";
        if (average >= 0.6)
            return;
        letterGrade = "U";
    }

    public void EnterGrade(int earnedValue, int possValue)
    {
        Earned.Add(earnedValue);
        Possible.Add(possValue);
    }
}

我不确定我做错了什么。谢谢你的帮助!

编辑:我继续在这里添加了大部分代码,希望能更好地回答您的问题。我正在处理的数据集是4行,它们被抓到学生数组中。

5 个答案:

答案 0 :(得分:1)

index2 + 1可能超出以下strArray[index2 + 1]中的范围:

while (index2 < strArray.Length)
{
    student.EnterGrade(int.Parse(strArray[index2]), int.Parse(strArray[index2 + 1]));
    index2 += 2;
}

要一次处理两个元素,请使用index2 < strArray.Length - 1

答案 1 :(得分:1)

如果path中的文件作为最后一行有空行,则可能会出现问题。 无论是否为空数组,都可以访问strArray[0], strArray[1], strArray[2]

答案 2 :(得分:0)

也许你错过了一个Array.resize()。 //这对我有用

Array.Resize<string[]>(ref strArrayList , count+ 1); // Count is the current length of strArrayList

答案 3 :(得分:0)

标记了可能遇到麻烦的两个地方:

public bool PopulateStudents(string path)
{
    theStudentList = new List<Student>();
    bool flag = false;
    try
    {
        List<string[]> strArrayList = new List<string[]>();
        using (StreamReader streamReader = new StreamReader(path))
        {
            string str;
            while ((str = streamReader.ReadLine()) != null)
            {
                string[] strArray = str.Split(',');
                strArrayList.Add(strArray);
            }
        }
        for (int index1 = 0; index1 < strArrayList.Count; ++index1)
        {
            string[] strArray = strArrayList[index1];
            // below that, what makes you believe strArray's length is >= 3 ?
            Student student = new Student(strArray[0], strArray[1], strArray[2]);
            int index2 = 3;
            while (index2 < strArray.Length)
            {
                // here index2 will be < strArray.Length, but index2+1 might be ==
                student.EnterGrade(int.Parse(strArray[index2]), int.Parse(strArray[index2 + 1]));
                index2 += 2;
            }
            student.CalGrade();
            theStudentList.Add(student);
        }
    }
    catch (Exception e)
    {
        flag = true;
        Console.WriteLine(e);
    }
    return flag;
}

请注意,您的while循环可以替换为:

for(int index2 = 3; index2 < strArray.Length - 1; index2 += 2)
{
    student.EnterGrade(...);
}

答案 4 :(得分:0)

这很难诊断,因为您提供的信息有限。如果我能看到你正在运行程序的文件,以路径形式输入,我将能够比较函数尝试做的事情以及它试图执行的数据。也就是说,这对我来说很熟悉所以我会尝试解决它,至少给你一个尝试它的工具。

我遇到了类似的问题,需要为图形程序读取CSV文件。问题是,创建CSV文件时,末尾会留下一个空行。这给我留下了一个空数组来表示文件中的最后一行。

另外,您是否验证过添加到strArrayList的数组的大小一致?

如果你在文件的末尾检查这个空行并且它不存在,如果你检查文件中行​​的末尾留下的逗号作为路径传递,那么你可以尝试我上面做的编辑了解CSV文件中的哪一行导致问题。我评论了我用“编辑:”编辑的所有编辑,因此它们很容易找到。没有更多的信息,我无法解决问题,但我可以帮助你找到正确的方向。

下面是编辑后的代码,其中包含文件中与错误相关的行号输出。祝你好运!

    public bool PopulateStudents(string path)
{
    theStudentList = new List<Student>();
    bool flag = false; 

    // EDIT: NEW VARIABLE int lineCounter declared and initialized before try block so it remains in scope when the catch block is called
    int counter = 0;

    try
    {
        List<string[]> strArrayList = new List<string[]>();
        using (StreamReader streamReader = new StreamReader(path))
        {
            string str;
            while ((str = streamReader.ReadLine()) != null)
            {
                string[] strArray = str.Split(',');
                strArrayList.Add(strArray);
            }
        }

        for (int index1 = 0; index1 < strArrayList.Count; ++index1)
        {
            // EDIT: UPDATE lineCounter
            ++lineCounter;

            string[] strArray = strArrayList[index1];
            Student student = new Student(strArray[0], strArray[1], strArray[2]);
            int index2 = 3;
            while (index2 < strArray.Length)
            {
                student.EnterGrade(int.Parse(strArray[index2]), int.Parse(strArray[index2 + 1]));
                index2 += 2;
            }
            student.CalGrade();
            theStudentList.Add(student);
        }
    }
    catch (Exception e)
    {
        flag = true;
        Console.WriteLine(e);

        // EDIT: PRINT CURRENT LINE
        Console.WriteLine(“error at line in file = “ + lineCounter);
    }
    return flag;
}