Changing Integer Value inside an if and else statement

Question

I'm trying to create some Java code in an if-and-else statement that goes between the two. When I run the code, the expected output should be: "hello world hello world" but all I get is "hello hello hello hello"

I have no clue what I'm doing wrong over here. Can somebody please tell me the problem?

int p = 1;

for (int i = 1; i < 5; i++) {
    if (p == 1) {    
        System.out.println("hello");
        p = 2;
    } else {
        System.out.println("world");
        p = 1;
    }
}

Answer 1

It isn't all the code you have in your program, but look here:

    else
        System.out.println("world");
    p = 1;
}

Last curly brace doesn't belong to the else part of if-else statement, it belongs to the for loop that encloses an if-else part - improve formatting of your code and you will see the difference. Your else part isn't surrounded with curly braces, so only the first line after else word is executed when the second condition is to be performed.

Answer 2

according to @ajb comment, you just move p = 1 to else block:

for (int i = 1; i < 5; i++) {
   if (p == 1) {
       System.out.print("hello");
       p = 2;
   } else {
      System.out.print("world\n");
      p = 1;
    }
}

Answer 3

You are missing a curly brace on the else block.

int p = 1;

for(int i = 1; i < 5; i++){
  if (p == 1){    
      System.out.println("hello");
      p = 2;
  }
  else {
      System.out.println("world");
      p = 1;
  }
}