循环链表:如何更正我的删除节点功能?

时间:2017-02-16 09:34:51

标签: c++ circular-list

我正在学习循环链表。调用deleteNodeByKey()删除头节点时遇到问题。它适用于其余节点以进行删除。如果删除节点是头,为什么它不起作用?

#include <iostream>
#include <stdlib.h>
using namespace std;

/* structure for a node */
struct node
{
    int data;
    struct node *next;
};

/* Function to insert a node at the begining of a Circular
   linked list */
void push(struct node **head_ref, int data)
{
    struct node *ptr = (struct node*)malloc(sizeof(struct node));
    ptr->data = data;
    ptr->next = *head_ref;
    struct node *temp = *head_ref;
     /* If linked list is not NULL then set the next of last node. 
        It is going to last node by circling 1 times.
     */
    if(*head_ref != NULL){
        while(temp->next != *head_ref){
            temp = temp->next;
        }
        //set last node by ptr
        temp->next = ptr;
    }
    else{
        // 1 node circular linked list
        ptr->next = ptr;
    }
    // after push ptr is the new node
    *head_ref = ptr;
}

//get the previous node
struct node* getPreviousNode(struct node* current_node){
    struct node* prev = current_node;
    while(prev->next != NULL && prev->next->data != current_node->data ){
        prev = prev->next;
    }
    return prev; 
}


/* Given a reference (pointer to pointer) to the head of a list
   and a key, deletes the first occurrence of key in linked list */
void deleteNodeByKey(struct node **head_ref, int key)
{
    // Store head node
    struct node* current_node = *head_ref, *prev;


    while(current_node != NULL && current_node->data != key){
        current_node = current_node->next;   
    }

    if(current_node == NULL){
        return;
    }

    //Removing the node
    if(current_node->data == key){
        prev = getPreviousNode(current_node);
        prev->next = current_node->next; 
        current_node->next = NULL;
        free(current_node);               
        return;
    }
}


/* Function to print nodes in a given Circular linked list */
void printList(struct node *head)
{
    struct node *temp = head;
    if(head != NULL){
        /*
            do-while because at 1st temp points head 
            and after 1 rotation temp wil come back to head again
        */
        do{
            cout<<temp->data<<' ';
            temp = temp->next;
        }
        while(temp != head);
        cout<<endl;
    }
}

int main() {
     /* Initialize lists as empty */
    struct node *head = NULL;
    /* Created linked list will be 11->2->56->12 */
    push(&head, 12);
    push(&head, 56);
    push(&head, 2);
    push(&head, 11);
    cout<<"Contents of Circular Linked List"<<endl;
    printList(head);

    deleteNodeByKey(&head, 11);
    printList(head);

    return 0;
}

以下是代码链接:Source Code

3 个答案:

答案 0 :(得分:2)

头节点不应该是链表的一部分,它应该是一个单独的节点,它保存链表的第一个节点的地址。因此,当你删除第一个节点时,让Head指向第一个节点的下一个节点,当你遵循这个结构时,head-node将像其他节点一样。 enter image description here

声明这样的头像:

struct node* head;
head = *first;

首先删除

head = head->next;
free(first);`

答案 1 :(得分:1)

为了解决与删除头部有关的问题。我总是发现创建一个虚拟节点并将头指针设置为该节点很有用。

node dummy;
dummy.next = *head_ref;

// Store head node
struct node* current_node = &dummy, *prev = &dummy;
current_node = current_node->next;

完成操作后,将头设置回dummy.next。通过这种方式,您不再需要跟踪特殊情况的头部,它可以被视为普通节点。您在此处修改了代码:deletion with dummy node

答案 2 :(得分:0)

在deleteNodeByKey()函数内部我添加一个if()块来重新分配头节点到它的下一个节点:

 //Removing the node
    if(current_node->data == key){
        //following if() is newly added
        //key is inside head node
        if(current_node == *head_ref ){
            //changing the head point to next
            *head_ref = current_node->next;
        }
        prev = getPreviousNode(current_node);
        prev->next = current_node->next; 
        current_node->next = NULL;
        free(current_node);               
        return;
    }