Question

我正在使用BCrypt加密密码，我有一个模型，我正在尝试编写测试。我已经制作了一个包含一些基本测试数据的YAML文件，但我似乎无法正确获取代码。

我的Account型号：

package models;

import javax.persistence.*;
import org.mindrot.jbcrypt.BCrypt;
import play.data.validation.Constraints.Required;
import play.db.ebean.Model;
import play.db.ebean.Model.Finder;

@Entity
public class Account extends Model {

    @Id
    public Long id;
    public String email;
    public String username;
    public String passwordhash;

    public Account(String email, String username, String password) {
        this.email = email;
        this.username = username;
        this.passwordhash = BCrypt.hashpw(password, BCrypt.gensalt()); 
    }

    public static Finder<Long, Account> find = new Finder<Long, Account>(Long.class, Account.class);

    public static Account create(
            String username, String email, String password, 
            String confirmPassword
    ) {
        Account account = new Account(username, email, password);
        account.save();
        return account;
    }

    public static Account authenticate (String username, String password) {
        Account account = Account.find.where().eq("username", username).findUnique();
        if (account != null && BCrypt.checkpw(password, account.passwordhash)) {
            return account;
        } else {
            return null;
        }
    }

}

我的模特测试：

package ModelTests;

import models.*;
import org.junit.*;
import com.avaje.ebean.Ebean;
import static org.junit.Assert.*;
import play.libs.Yaml;
import play.test.WithApplication;
import static play.test.Helpers.*;

import java.util.List;

public class AccountTest extends WithApplication {

    @Before
    public void setUp() {
        start(fakeApplication(inMemoryDatabase()));
        Ebean.save((List) Yaml.load("test-data.yml"));
    }

    @Test
    public void authentication() {
        assertNotNull(Account.authenticate("palug", "Oxford4EVA"));
        assertNotNull(Account.authenticate("isthatastrawhat", "Supernatural"));
        assertNull(Account.authenticate("MelvIsntNormal", "meaplesss"));
        assertNull(Account.authenticate("SomeStupidHacker", "dogewow"));
    }

}

我的测试数据YAML：

# Accounts

- &melvin !!models.Account
    email: mxtcapps@maxtrace.co.uk
    username: MelvIsntNormal
    password: HashedPassword

- &emma !!models.Account
    email: isthatastrawhat@maxtrace.co.uk
    username: isthatastrawhat
    password: Supernatural

- &paul !!models.Account
    email: palug@maxtrace.co.uk
    username: palug
    password: Oxford4EVA

当我运行测试时，我收到此错误：

[error] Test ModelTests.AccountTest.authentication failed: org.yaml.snakeyaml.constructor.ConstructorException: null; Can't construct a java object for tag:yaml.org,2002:models.Account; exception=Cannot create property=password for JavaBean=models.Account@1c8d2d9; Unable to find property 'password' on class: models.Account;  in 'reader', line 3, column 3:
[error]     - &melvin !!models.Account
[error]       ^
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructYamlObject.construct(Constructor.java:333)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.constructObject(BaseConstructor.java:182)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.constructSequenceStep2(BaseConstructor.java:276)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.constructSequence(BaseConstructor.java:247)
[error]     at org.yaml.snakeyaml.constructor.SafeConstructor$ConstructYamlSeq.construct(SafeConstructor.java:442)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.constructObject(BaseConstructor.java:182)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.constructDocument(BaseConstructor.java:141)
[error]     at org.yaml.snakeyaml.constructor.BaseConstructor.getSingleData(BaseConstructor.java:127)
[error]     at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:481)
[error]     at org.yaml.snakeyaml.Yaml.load(Yaml.java:412)
[error]     at play.libs.Yaml.load(Yaml.java:31)
[error]     at play.libs.Yaml.load(Yaml.java:18)
[error]     at ModelTests.AccountTest.setUp(AccountTest.java:18)
[error]     ...
[error] Caused by: org.yaml.snakeyaml.error.YAMLException: Cannot create property=password for JavaBean=models.Account@1c8d2d9; Unable to find property 'password' on class: models.Account
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.constructJavaBean2ndStep(Constructor.java:299)
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.construct(Constructor.java:189)
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructYamlObject.construct(Constructor.java:331)
[error]     ... 48 more
[error] Caused by: org.yaml.snakeyaml.error.YAMLException: Unable to find property 'password' on class: models.Account
[error]     at org.yaml.snakeyaml.introspector.PropertyUtils.getProperty(PropertyUtils.java:132)
[error]     at org.yaml.snakeyaml.introspector.PropertyUtils.getProperty(PropertyUtils.java:121)
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.getProperty(Constructor.java:308)
[error]     at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.constructJavaBean2ndStep(Constructor.java:240)
[error]     ... 50 more
[info] ModelTests.AccountTest
[info] x authentication
[info] 
[info] 
[info] Total for test ModelTests.AccountTest
[info] Finished in 0.039 seconds
[info] 1 tests, 1 failures, 0 errors
[error] Failed: Total 1, Failed 1, Errors 0, Passed 0
[error] Failed tests:
[error]     ModelTests.AccountTest
[error] (test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 26 s, completed 01-Feb-2014 07:59:02

我理解错误是由密码字段不存在引起的。但是，我不太确定如何让测试调用Account方法，以便密码加密。任何人都可以帮忙吗？

问题答案（谢谢@Joe）

我必须为密码字段添加一个setter方法：

public void setPassword(String password) {
        this.passwordhash = BCrypt.hashpw(password, BCrypt.gensalt());
}

我的Account模型现在看起来像这样：包模型;

import javax.persistence.*;
import org.mindrot.jbcrypt.BCrypt;
import play.data.validation.Constraints.Required;
import play.db.ebean.Model;
import play.db.ebean.Model.Finder;

@Entity
public class Account extends Model {

    @Id
    public Long id;
    public String email;
    public String username;
    public String passwordhash;

    public Account(String email, String username, String password) {
        this.email = email;
        this.username = username;
        this.passwordhash = BCrypt.hashpw(password, BCrypt.gensalt()); 
    }

    public static Finder<Long, Account> find = new Finder<Long, Account>(Long.class, Account.class);

    public static Account create(
            String username, String email, String password, 
            String confirmPassword
    ) {
        Account account = new Account(username, email, password);
        account.save();
        return account;
    }

    public void setPassword(String password) {
        this.passwordhash = BCrypt.hashpw(password, BCrypt.gensalt());
    }

    public static Account authenticate (String username, String password) {
        Account account = Account.find.where().eq("username", username).findUnique();
        if (account != null && BCrypt.checkpw(password, account.passwordhash)) {
            return account;
        } else {
            return null;
        }
    }

}

Answer 1

该错误表示您的models.Account类没有password属性。 SnakeYAML正在寻找either a public field called password or a JavaBeans setter method called setPassword：

默认情况下，包含标准JavaBean属性和公共字段。

它既没有发现：

[error] Caused by: org.yaml.snakeyaml.error.YAMLException: Unable to find property 'password' on class: models.Account

相反，它有一个passwordHash字段。这表明有两种可能性：

在测试数据中定义passwordHash。
在setPassword(String)上定义一个models.Account方法，该方法将对密码进行哈希并将其存储在passwordHash中。

测试应该做一件事，所以我建议第一件事。您正在根据已知密码测试身份验证。将散列定义为测试的一部分意味着您可以在测试数据中看到已知密码的散列，并避免在面对错误时传递的测试（例如）hashpw方法始终返回空字符串。

使用BCrypt加载测试数据

1 个答案: